arduino/esp-clock
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

simplify timer by using first iteration functionality of the task - avoid using start and decreasing value on first iteration

Browse Source
This commit is contained in:
Nicu Hodos 2025-09-29 10:47:34 +02:00
parent 5421e52bf4
commit 2c0346680d
2 changed files with 12 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
include/display.h
View File

@ -85,22 +85,20 @@ namespace Display {
[]{
if (!displayTask.isPerm(tDisplayTimer)) displayTask.restorePerm();
});
constexpr uint8 threshold = 16;
Task tTimer(MINUTES(1), TASK_FOREVER,
[]{
static constexpr uint8 threshold = 16;
timer.decrease();
if (timer.atBeginning()) {
if (tTimer.isFirstIteration()) {
if (timer <= threshold) tDisplayTimer.setIterations(TASK_FOREVER);
displayTask.activate(tDisplayTimer);
} else if (timer == threshold) {
tDisplayTimer.setIterations(TASK_FOREVER);
displayTask.activate(tDisplayTimer);
} else {
timer.decrease();
if (timer == threshold) {
tDisplayTimer.setIterations(TASK_FOREVER);
displayTask.activate(tDisplayTimer);
}
}
}, &ts, false,
[]{
timer.start();
return true;
},
}, &ts, false, nullptr,
[]{
tDisplayTimer.setIterations(TASK_ONCE + 1);
displayTask.activate(tDisplayTime);

14
include/timer.h
View File

@ -7,25 +7,17 @@ struct : public CallbackAware<remaining_callback_t> {
void operator=(int8 value) {
remaining = value;
if (callback) callback(remaining);
}
operator int8() {
return remaining;
}
void start() {
initial = remaining++;
}
void decrease() {
remaining--;
if (callback) callback(remaining);
}
bool atBeginning() {
return initial == remaining;
*this = remaining - 1;
}
private:
int8 initial = 0, remaining = 0;
int8 remaining = 0;
} timer;